pussuw commented on code in PR #16344:
URL: https://github.com/apache/nuttx/pull/16344#discussion_r2081303089
##########
arch/arm/src/armv7-a/arm_addrenv_utils.c:
##########
@@ -97,7 +96,9 @@ int arm_addrenv_create_region(uintptr_t **list, unsigned int
listlen,
nmapped = 0;
for (i = 0; i < nlist; i++)
{
- /* Allocate one physical page for the L2 page table */
+ /* Allocate one physical page for the L2 page table
+ * Makesure physical page is sequential, alloc all l2 table first.
Review Comment:
Ok, so some driver assumes that a contiguous virtual address space is also
contiguous in physical, I presume for DMA? or what, missing scatter gather
implementation? I'm confused.
You should add a REVISIT or something here, because this is not right for
sure, there is a bug / missing implementation somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]