michallenc commented on PR #3097:
URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-3001448204

   > It's irrelevant now but, for completeness, my use case is fine and still 
works OK.
   
   Thanks for the check!
   
   > I do wonder, though, if the the new `NXBOOT_PROGRESS` was actually 
necessary? Since this is only relevant if `NXBOOT_BOOTLOADER` is selected, that 
could have been used as the guarding `#ifdef` rather than forcibly selecting a 
hidden config setting? But, oh well.
   
   Yes, you are right, the usage is tighten to `NXBOOT_BOOTLOADER`, but that is 
true only if you use bootloader application from the mainline. But you may 
write your own `nxboot_main.c` (because some specific implementation 
requirements), have `NXBOOT_BOOTLOADER` selected and no need for the logging at 
all. Thus we can avoid the need to define `nxboot_progress` function in custom 
`nxboot_main.c`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to