jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2185450555
########## sched/sched/sched_setpriority.c: ########## @@ -231,8 +223,7 @@ static inline void nxsched_running_setpriority(FAR struct tcb_s *tcb, #ifdef CONFIG_SMP int cpu = this_cpu(); - if (tcb->cpu != cpu && - tcb->task_state == TSTATE_TASK_RUNNING) Review Comment: It is always true, there is no point in checking again. We are in "running_setpriority". See where this is called from (in critical section). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org