Re: [PR] reduce the dup of errno and errno str, add host_errno_convert method [nuttx]

[via GitHub]

xiaoxiang781216 commented on code in PR #16666:
URL: https://github.com/apache/nuttx/pull/16666#discussion_r2226013927


##########
arch/sim/src/sim/posix/sim_hostusrsock.c:
##########
@@ -234,7 +234,7 @@ static int host_usrsock_sockopt(int sockfd, int level, int 
optname,
       ret = getsockopt(sockfd, level, optname, (void *)optval, optlen);
     }
 
-  return ret < 0 ? -errno : 0;
+  return ret < 0 ? host_errno_convert(-errno) : 0;

Review Comment:
   need call host_uninterruptible before touch errno, let's create a new patch 
to fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org