xiaoxiang781216 commented on code in PR #16666:
URL: https://github.com/apache/nuttx/pull/16666#discussion_r2228637029
##########
arch/sim/src/sim/posix/sim_host_v4l2.c:
##########
@@ -187,7 +189,7 @@ int host_video_start_capture(struct host_video_dev_s *vdev)
if (-1 == host_video_ioctl(vdev->fd, VIDIOC_REQBUFS, &reqbuf))
Review Comment:
should we wrap all host call with host_uninterruptible_errno
##########
arch/sim/src/sim/posix/sim_host_v4l2.c:
##########
@@ -140,7 +142,7 @@ int host_video_dqbuf(struct host_video_dev_s *vdev, uint8_t
*addr,
default:
perror("VIDIOC_DQBUF");
- return -errno;
+ return host_errno_convert(-errcode);
Review Comment:
need return errno from host_errno_convert with irq_disable to avoid losing
errno
##########
arch/sim/src/sim/posix/sim_host_v4l2.c:
##########
@@ -153,7 +155,7 @@ int host_video_dqbuf(struct host_video_dev_s *vdev, uint8_t
*addr,
if (-1 == ioctl(vdev->fd, VIDIOC_QBUF, &buf))
Review Comment:
call host_video_ioctl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
