linguini1 commented on issue #17004: URL: https://github.com/apache/nuttx/issues/17004#issuecomment-3275704750
> I didn't know of the app to calibrate this... That makes two of us! I didn't learn about this until I encountered the busy-loop sleep options when writing a driver. It was told to me by one of the contributors. > but it depends on whether you compile with full optimization, so that's a further subtle factor here! Hmmmm. I didn't consider that. It almost needs to be done on a per-image basis. I guess that could be mentioned in the docs so that people can properly calibrate their boards before making some production binary. > By setting the default to -1 rather than 5000 for boards seems a good idea to me, but a -1 setting that throws an error might be confusing to NuttX newcomers? They now have to get an app built-in right away, just to calibrate this before they even get started? > > Perhaps a new default "magic" value could be caught during compile, re-mapped to (say) 5000 but with a compiler #warning to commend a calibration be done by the user some time soone? I think a warning instead of an error is fine! I would still prefer a `-1` value with an error though personally. If a newcomer wants to skip calibrating it first (which hopefully they shouldn't have to anyway, prebuilt defconfigs have pretty decent values), they can just set the Kconfig value to something else and compile again. At that point, if something doesn't work, they were at least made aware! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
