jlaitine commented on code in PR #17010:
URL: https://github.com/apache/nuttx/pull/17010#discussion_r2347160399
##########
boards/boardctl.c:
##########
@@ -133,16 +133,25 @@ static inline int
case BOARDIOC_USBDEV_CONNECT: /* Connect the CDC/ACM device */
#ifndef CONFIG_CDCACM_COMPOSITE
{
- DEBUGASSERT(ctrl->handle != NULL);
ret = cdcacm_initialize(ctrl->instance, ctrl->handle);
}
#endif
break;
case BOARDIOC_USBDEV_DISCONNECT: /* Disconnect the CDC/ACM device
*/
{
- DEBUGASSERT(ctrl->handle != NULL && *ctrl->handle != NULL);
- cdcacm_uninitialize(*ctrl->handle);
+#ifdef CONFIG_SYSTEM_CDCACM
+ if (ctrl->instance == CONFIG_SYSTEM_CDCACM_DEVMINOR)
+ {
+ ret = cdcacm_uninitialize_system_cdcacm();
+ }
+ else
+#endif
+ {
+ DEBUGASSERT(ctrl->handle != NULL &&
+ *ctrl->handle != NULL);
+ cdcacm_uninitialize(*ctrl->handle);
Review Comment:
Sure, it would be more generic of course. Although, instead of making
another list, I'd rather just search the drivers by device node name from
filesystem in that case.
I actually have a draft ready, I'll clean it up, test and push it tomorrow
for review, perhaps it is better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
