linguini1 commented on code in PR #17007: URL: https://github.com/apache/nuttx/pull/17007#discussion_r2353740425
########## arch/arm/src/stm32h5/stm32_adc.h: ########## @@ -498,8 +521,8 @@ extern "C" struct adc_dev_s; struct adc_dev_s *stm32h5_adc_initialize(int intf, - const uint8_t *chanlist, - int nchannels); + struct stm32_adc_channel_s *chanlist + , int nchannels); Review Comment: I think this is a valid criticism of existing NuttX code. If there's no ability in existing drivers to handle differential channel and multiple watchdogs, then either we don't have that feature at all, or there's some new structure added. In general I agree consistency is important, but functionality is too. We can't expect a patch to other families necessarily, although it would be nice. I think if other users need this functionality, they can port it to the other families. Then it's still consistent where this functionality is needed. Does this implementation break anything regarding an actual breaking change? If not, I think Kyle has provided pretty good justification of why this implementation is necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
