acassis commented on code in PR #17007: URL: https://github.com/apache/nuttx/pull/17007#discussion_r2353547243
########## arch/arm/src/stm32h5/stm32_adc.h: ########## @@ -498,8 +521,8 @@ extern "C" struct adc_dev_s; struct adc_dev_s *stm32h5_adc_initialize(int intf, - const uint8_t *chanlist, - int nchannels); + struct stm32_adc_channel_s *chanlist + , int nchannels); Review Comment: @kywwilson11 everything you said is true and we are grateful for you and your company to adding support for STM32H5. What @raiden00pl is trying to say is: it is important that all STM32 families share similar drivers API, it make the code easier to maintain and a fix that is applied to STM32xx could be moved easily to STM32yy, STM32zz, etc. if you added an improvement that could be included to others STM32 families, it would be nice to add it to there families. But we know sometimes it is a huge task and requires a HW to test it. Imagine the burden of other people adding later improvement to STM32 drivers if each family has a very different driver? We know maybe you don't want to spend some time fixing it now, but not doing it means making the work for other people in the future even harder than the work you will need to have now to improve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
