xiaoxiang781216 commented on code in PR #17010:
URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344553312
##########
drivers/usbdev/cdcacm.c:
##########
@@ -254,6 +254,10 @@ static void cdcuart_dmareceive(FAR struct uart_dev_s
*dev);
static FAR struct cdcacm_dev_s *g_syslog_cdcacm;
#endif
+#ifdef CONFIG_SYSTEM_CDCACM
+FAR struct usbdevclass_driver_s *g_system_cdcacm;
Review Comment:
where we really use g_system_cdcacm?
##########
boards/boardctl.c:
##########
@@ -133,16 +133,25 @@ static inline int
case BOARDIOC_USBDEV_CONNECT: /* Connect the CDC/ACM device */
#ifndef CONFIG_CDCACM_COMPOSITE
{
- DEBUGASSERT(ctrl->handle != NULL);
ret = cdcacm_initialize(ctrl->instance, ctrl->handle);
}
#endif
break;
case BOARDIOC_USBDEV_DISCONNECT: /* Disconnect the CDC/ACM device
*/
{
- DEBUGASSERT(ctrl->handle != NULL && *ctrl->handle != NULL);
- cdcacm_uninitialize(*ctrl->handle);
+#ifdef CONFIG_SYSTEM_CDCACM
+ if (ctrl->instance == CONFIG_SYSTEM_CDCACM_DEVMINOR)
+ {
+ ret = cdcacm_uninitialize_system_cdcacm();
+ }
+ else
+#endif
+ {
+ DEBUGASSERT(ctrl->handle != NULL &&
+ *ctrl->handle != NULL);
+ cdcacm_uninitialize(*ctrl->handle);
Review Comment:
why cdcacm_uninitialize doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
