jlaitine commented on code in PR #17010:
URL: https://github.com/apache/nuttx/pull/17010#discussion_r2348078274
##########
boards/boardctl.c:
##########
@@ -133,16 +133,25 @@ static inline int
case BOARDIOC_USBDEV_CONNECT: /* Connect the CDC/ACM device */
#ifndef CONFIG_CDCACM_COMPOSITE
{
- DEBUGASSERT(ctrl->handle != NULL);
ret = cdcacm_initialize(ctrl->instance, ctrl->handle);
}
#endif
break;
case BOARDIOC_USBDEV_DISCONNECT: /* Disconnect the CDC/ACM device
*/
{
- DEBUGASSERT(ctrl->handle != NULL && *ctrl->handle != NULL);
- cdcacm_uninitialize(*ctrl->handle);
+#ifdef CONFIG_SYSTEM_CDCACM
+ if (ctrl->instance == CONFIG_SYSTEM_CDCACM_DEVMINOR)
+ {
+ ret = cdcacm_uninitialize_system_cdcacm();
+ }
+ else
+#endif
+ {
+ DEBUGASSERT(ctrl->handle != NULL &&
+ *ctrl->handle != NULL);
+ cdcacm_uninitialize(*ctrl->handle);
Review Comment:
I now added a new function (find_driver) under fs/driver, and use that in
cdcacm driver to get the driver instance. This works the same now for all the
cdcacm instances (the boardctrl ioctl can connect/disconnect by the cdcacm
number).
Also the same mechanism is usable for any driver which registers itself into
the filesystem, if such needed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
