raiden00pl commented on code in PR #17352:
URL: https://github.com/apache/nuttx/pull/17352#discussion_r2545611288
##########
sched/pthread/pthread_exit.c:
##########
@@ -75,9 +75,10 @@ void nx_pthread_exit(FAR void *exit_value)
/* Block any signal actions that would awaken us while were
* are performing the JOIN handshake.
*/
-
+#ifndef CONFIG_DISABLE_SIGNALS
sigfillset(&set);
nxsig_procmask(SIG_SETMASK, &set, NULL);
Review Comment:
fix warning:
```
/home/raiden00/git/railab/railab_nuttx_code/external/nuttx/sched/pthread/pthread_exit.c:68:12:
warning: unused variable 'set' [-Wunused-variable]
68 | sigset_t set;
```
##########
sched/task/task_setup.c:
##########
@@ -457,11 +457,13 @@ static int nxthread_setup_scheduler(FAR struct tcb_s
*tcb, int priority,
nxtask_inherit_affinity(tcb);
#endif
+#ifndef CONFIG_DISABLE_SIGNALS
/* exec(), pthread_create(), task_create(), and vfork() all
* inherit the signal mask of the parent thread.
*/
tcb->sigprocmask = rtcb->sigprocmask;
Review Comment:
fix warning:
```
/home/raiden00/git/railab/railab_nuttx_code/external/nuttx/sched/task/task_setup.c:406:21:
warning: unused variable 'rtcb' [-Wunused-variable]
406 | FAR struct tcb_s *rtcb = this_task();
```
##########
include/nuttx/signal.h:
##########
@@ -696,6 +698,28 @@ void nxsig_cancel_notification(FAR struct sigwork_s *work);
# define nxsig_cancel_notification(work)
#endif
+#else
+
+# define nxsig_ismember(set,sig) -EINVAL
Review Comment:
fix warning in fs_epoll.c:
```
/home/raiden00/git/railab/railab_nuttx_code/external/nuttx/fs/vfs/fs_epoll.c:727:12:
warning: unused variable 'oldsigmask' [-Wunused-variable]
727 | sigset_t oldsigmask;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
