acassis commented on code in PR #17408:
URL: https://github.com/apache/nuttx/pull/17408#discussion_r2573198040
##########
include/nuttx/uorb.h:
##########
@@ -630,184 +630,184 @@
* reported.
*/
-struct sensor_event /* Type: Sensor Common Event */
+struct sensor_event /* Type: Sensor Common Event */
{
- uint64_t timestamp; /* Units is microseconds */
- uint32_t event; /* Common events */
+ uint64_t timestamp; /* Units is microseconds */
+ uint32_t event; /* Common events */
};
-struct sensor_accel /* Type: Accerometer */
+struct sensor_accel /* Type: Accerometer */
{
- uint64_t timestamp; /* Units is microseconds */
- float x; /* Axis X in m/s^2 */
- float y; /* Axis Y in m/s^2 */
- float z; /* Axis Z in m/s^2 */
- float temperature; /* Temperature in degrees celsius */
+ uint64_t timestamp; /* Units is microseconds */
+ sensor_data_t x; /* Axis X in m/s^2 */
+ sensor_data_t y; /* Axis Y in m/s^2 */
+ sensor_data_t z; /* Axis Z in m/s^2 */
+ sensor_data_t temperature; /* Temperature in degrees celsius */
};
-struct sensor_mag /* Type: Magnetic Field */
+struct sensor_mag /* Type: Magnetic Field */
{
- uint64_t timestamp; /* Units is microseconds */
- float x; /* Axis X in Gauss or micro Tesla (uT) */
- float y; /* Axis Y in Gauss or micro Tesla (uT) */
- float z; /* Axis Z in Gauss or micro Tesla (uT) */
- float temperature; /* Temperature in degrees celsius */
- int32_t status; /* Status of calibration */
+ uint64_t timestamp; /* Units is microseconds */
+ sensor_data_t x; /* Axis X in Gauss or micro Tesla (uT) */
+ sensor_data_t y; /* Axis Y in Gauss or micro Tesla (uT) */
+ sensor_data_t z; /* Axis Z in Gauss or micro Tesla (uT) */
+ sensor_data_t temperature; /* Temperature in degrees celsius */
+ int32_t status; /* Status of calibration */
};
-struct sensor_orientation /* Type: Orientation */
+struct sensor_orientation /* Type: Orientation */
{
- uint64_t timestamp; /* Units is microseconds */
- float x; /* azimuth */
- float y; /* pitch */
- float z; /* roll */
+ uint64_t timestamp; /* Units is microseconds */
+ sensor_data_t x; /* azimuth */
Review Comment:
@raiden00pl seems like you used some script to change the float to
sensor_data_t, but the alignment of the variables from previous and following
lines became wrong.
I think you can use the script to fix the "uint64_t timestamp;" alignment,
but the other fields will need some manual work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
