acassis commented on code in PR #17410:
URL: https://github.com/apache/nuttx/pull/17410#discussion_r2576709508
##########
arch/arm64/src/imx9/imx9_enet.c:
##########
@@ -1285,7 +1292,7 @@ static void imx9_txtimeout_expiry(wdparm_t arg)
* canceling any pending interrupt work.
*/
- work_queue(ETHWORK, &priv->irqwork, imx9_txtimeout_work, priv, 0);
Review Comment:
@jlaitine I suggest you include a clear message there warning about it,
otherwise someone else revising this code in the future will think someone
forgot to use ETHWORK there and will "fix it"
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -1013,6 +1013,12 @@ config IMX9_ENET_USE_OTP_MAC
default n
depends on IMX9_ENET
+config IMX9_ENET_HPWORK
+ bool "Use high priority work queue for ethernet"
+ depends on IMX9_ENET
+ depends on SCHED_HPWORK
+ default n
Review Comment:
All config with user text needs to have a help to let users understand the
consequences of enabling that option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
