michallenc commented on code in PR #17441: URL: https://github.com/apache/nuttx/pull/17441#discussion_r2596512249
########## drivers/can/can.c: ########## @@ -518,7 +518,7 @@ static ssize_t can_read(FAR struct file *filep, FAR char *buffer, /* ret can be more than buflen due to roundup, so return at most buflen */ - return ret ? MIN(ret, buflen) : -EMSGSIZE; + return ret ? MIN(ret, (int)buflen) : -EMSGSIZE; Review Comment: `ret` doesn't seem to be set to `-EMSGSIZE` in the code now, so the original if in the return has to stay (or we need some other changes in the code, possibly another if statement after do while loop that sets the errno if `ret == 0`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
