raiden00pl commented on code in PR #17441: URL: https://github.com/apache/nuttx/pull/17441#discussion_r2597649315
########## drivers/can/can.c: ########## @@ -518,7 +518,7 @@ static ssize_t can_read(FAR struct file *filep, FAR char *buffer, /* ret can be more than buflen due to roundup, so return at most buflen */ - return ret ? MIN(ret, buflen) : -EMSGSIZE; + return ret ? MIN(ret, (int)buflen) : -EMSGSIZE; Review Comment: @acassis new framework wouldn't help here at the moment, as there are no test cases that could detect this regression (but will be available later). Simulator supports now CAN interface on Linux so it's possible to implement quite complex CAN tests and that's what I'm doing in one of my priv projects. With NTFC we can fully automate this even easier, but this require some work to be finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
