wangchdo commented on PR #17556: URL: https://github.com/apache/nuttx/pull/17556#issuecomment-3670319229
> > Guys, instead of compete to see who implemented first or which implementation has best performance, it is better to work together to get best part of each implementation and contribute a better solution to NuttX. > > > > > > This features is very important to everyone using NuttX (not only LiAuto or Xiaomi). > > > > > > @Fix-Point and @anchao please align between you both how to integrate it in a way that the best interest is the project quality, not individual ego. > > > > I agree. > > > > The main problem is that NuttX should consider all application scenarios, including IoT devices, automotive, multi-core embedded devices, and etc. But, @wangchdo only considered his `tc397` board in his design, adding so many ugly workarounds to NuttX kernel just to fix the Tricore timer issues. I believe such code and implementation should be removed later. > > > > I believe the community should encourage better implementations, rather than more meaningless, performance-inefficient, and product-specific implementations. > > > > For the HRtimer, I believe my implementation is better in performance, composability and general. So I insist this hrtimer is a better implementation, not just "a optimization for their hrtimer". I suggest they added optimization on this implementation, that's my opinion. > > > > By the way, It is so funny that every time @wangchdo claims all I have done looks like his work, although these are completely different things. > > > > > @xiaoxiang781216 @Fix-Point This looks similar to the hrtimer driver I planned to add in my PR #17065, which was intended to provide access to the hardware timer count. > > > > > > However, @xiaoxiang781216 mentioned in that PR that adding a new timer driver is not allowed in NuttX, so I removed the implementation, and reimplemented the sched/hrtimer based on the exsiting timer driver. > > > > > > Your PR to introcude ClockDevice makes me feel confused about the criteria for what kind of functionality is acceptable to add to NuttX... > > I don't think it is polite to attack other personally, i am just a personal contributor, and my PR got merged only when they are approved by committers or PMC. If you think they are ugly, you are welcome to provide comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
