xiaoxiang781216 commented on code in PR #3248: URL: https://github.com/apache/nuttx-apps/pull/3248#discussion_r2631189943
########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,217 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) +#define NSEC_MARGIN (5) + +/* Simple assertion macro for HRTimer test cases */ +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: HRTimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +/* Structure for HRTimer test tracking */ + +struct hrtimer_test_s +{ + hrtimer_t timer; /* HRTimer instance */ + uint64_t previous; /* Previous timestamp in nanoseconds */ + uint64_t now; /* Current timestamp in nanoseconds */ + uint32_t count; /* Number of timer expirations */ + uint32_t period; /* Expected period between expirations */ + bool active; /* True while the test is still running */ +}; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_test_init + * + * Description: + * Initialize a hrtimer_test_s structure for a new test. + * + * Input Parameters: + * test_hrtimer - Pointer to the test structure to initialize + * period - Expected timer period in nanoseconds + * + * Returned Value: + * None + * + ****************************************************************************/ + +static void hrtimer_test_init(FAR struct hrtimer_test_s *test_hrtimer, + uint32_t period) +{ + test_hrtimer->previous = 0; + test_hrtimer->now = 0; + test_hrtimer->count = 0; + test_hrtimer->active = true; + test_hrtimer->period = period; +} + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * HRTimer callback function for test. + * + * - Verifies the timer interval is exactly 500ms (nanosecond precision) + * - Stops the test after 15 expirations + * - Re-arms the timer in absolute mode + * + * Input Parameters: + * hrtimer - Pointer to the expired HRTimer instance + * + * Returned Value: + * Timer period in nanoseconds (NSEC_PER_500MS) + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + struct timespec ts; + uint32_t diff; + int ret; + + FAR struct hrtimer_test_s *test = + (FAR struct hrtimer_test_s *)hrtimer; + + /* Increment expiration count */ + + test->count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + test->now = clock_time2nsec(&ts); + + /* Skip comparison for first two invocations */ + + if (test->count > 2) + { + /* Verify the timer interval is exactly + * 500ms with nsec resolution + */ + + diff = (uint32_t)(test->now - test->previous); + + HRTIMER_TEST(NSEC_PER_500MS < diff + NSEC_MARGIN, true); + HRTIMER_TEST(NSEC_PER_500MS > diff - NSEC_MARGIN, true); + } + + test->previous = test->now; + + /* Stop the test after 15 expirations */ + + if (test->count >= 15) Review Comment: ```suggestion if (test->count >= 15) ``` ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,217 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) +#define NSEC_MARGIN (5) + +/* Simple assertion macro for HRTimer test cases */ +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: HRTimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +/* Structure for HRTimer test tracking */ + +struct hrtimer_test_s +{ + hrtimer_t timer; /* HRTimer instance */ + uint64_t previous; /* Previous timestamp in nanoseconds */ + uint64_t now; /* Current timestamp in nanoseconds */ + uint32_t count; /* Number of timer expirations */ + uint32_t period; /* Expected period between expirations */ + bool active; /* True while the test is still running */ +}; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_test_init + * + * Description: + * Initialize a hrtimer_test_s structure for a new test. + * + * Input Parameters: + * test_hrtimer - Pointer to the test structure to initialize + * period - Expected timer period in nanoseconds + * + * Returned Value: + * None + * + ****************************************************************************/ + +static void hrtimer_test_init(FAR struct hrtimer_test_s *test_hrtimer, + uint32_t period) +{ + test_hrtimer->previous = 0; + test_hrtimer->now = 0; + test_hrtimer->count = 0; + test_hrtimer->active = true; + test_hrtimer->period = period; +} + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * HRTimer callback function for test. + * + * - Verifies the timer interval is exactly 500ms (nanosecond precision) + * - Stops the test after 15 expirations + * - Re-arms the timer in absolute mode + * + * Input Parameters: + * hrtimer - Pointer to the expired HRTimer instance + * + * Returned Value: + * Timer period in nanoseconds (NSEC_PER_500MS) + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + struct timespec ts; + uint32_t diff; + int ret; + + FAR struct hrtimer_test_s *test = + (FAR struct hrtimer_test_s *)hrtimer; + + /* Increment expiration count */ + + test->count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + test->now = clock_time2nsec(&ts); + + /* Skip comparison for first two invocations */ + + if (test->count > 2) + { + /* Verify the timer interval is exactly + * 500ms with nsec resolution + */ + + diff = (uint32_t)(test->now - test->previous); + + HRTIMER_TEST(NSEC_PER_500MS < diff + NSEC_MARGIN, true); + HRTIMER_TEST(NSEC_PER_500MS > diff - NSEC_MARGIN, true); + } + + test->previous = test->now; Review Comment: change now to local variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
