xiaoxiang781216 commented on code in PR #3248: URL: https://github.com/apache/nuttx-apps/pull/3248#discussion_r2625315129
########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; + static uint64_t now = 0; + static uint32_t count = 0; + + struct timespec ts; + int ret; + + count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + now = clock_time2nsec(&ts); + + /* Skip comparison for the first invocation */ + + if (previous != 0 && count > 2) Review Comment: remove previous check ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; + static uint64_t now = 0; Review Comment: why need static ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; Review Comment: add g_ prefix ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; Review Comment: how to handle the run ostest repeatly ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; + static uint64_t now = 0; + static uint32_t count = 0; + + struct timespec ts; + int ret; + + count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + now = clock_time2nsec(&ts); + + /* Skip comparison for the first invocation */ + + if (previous != 0 && count > 2) + { + /* Verify the timer interval is exactly + * 500ms with nsec resolution + */ + + HRTIMER_TEST(now - previous, NSEC_PER_500MS); + } + + previous = now; + + /* Stop the test after 15 expirations */ Review Comment: but the loop is 10 times ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; + static uint64_t now = 0; + static uint32_t count = 0; + + struct timespec ts; + int ret; + + count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + now = clock_time2nsec(&ts); + + /* Skip comparison for the first invocation */ + + if (previous != 0 && count > 2) + { + /* Verify the timer interval is exactly + * 500ms with nsec resolution + */ + + HRTIMER_TEST(now - previous, NSEC_PER_500MS); + } + + previous = now; + + /* Stop the test after 15 expirations */ + + if (count >= 10) + { + ret = hrtimer_cancel(&test_hrtimer_500ms); Review Comment: should return zero represent the cancel ########## testing/ostest/hrtimer.c: ########## @@ -0,0 +1,180 @@ +/**************************************************************************** + * apps/testing/ostest/hrtimer.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/hrtimer.h> + +#include <stdio.h> +#include <sched.h> +#include <pthread.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define NSEC_PER_500MS (500 * NSEC_PER_MSEC) + +/* Simple assertion macro for hrtimer test cases */ + +#define HRTIMER_TEST(expr, value) \ + do \ + { \ + ret = (expr); \ + if (ret != (value)) \ + { \ + printf("ERROR: hrtimer test failed, line=%d ret=%d\n", \ + __LINE__, ret); \ + ASSERT(false); \ + } \ + } \ + while (0) + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* High resolution timer instance used for 500ms periodic test */ + +static hrtimer_t test_hrtimer_500ms; + +/* Indicate whether the hrtimer test is still running */ + +static bool hrtimer_test_running = false; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: test_hrtimer_callback + * + * Description: + * High resolution timer callback function. This callback verifies + * that the actual expiration interval is exactly 500ms (nanosecond + * precision) and re-arms the timer in absolute mode. + * + * The timer will be cancelled after it fires 15 times. + * + * Input Parameters: + * hrtimer - Pointer to the expired high resolution timer instance + * + * Returned Value: + * None + * + ****************************************************************************/ + +static uint32_t test_hrtimer_callback(FAR hrtimer_t *hrtimer) +{ + static uint64_t previous = 0; + static uint64_t now = 0; + static uint32_t count = 0; + + struct timespec ts; + int ret; + + count++; + + /* Get current system time */ + + clock_systime_timespec(&ts); + now = clock_time2nsec(&ts); + + /* Skip comparison for the first invocation */ + + if (previous != 0 && count > 2) + { + /* Verify the timer interval is exactly + * 500ms with nsec resolution + */ + + HRTIMER_TEST(now - previous, NSEC_PER_500MS); Review Comment: should we need add some margin here? do you run this test on sim/qemu and real device? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
