wangchdo commented on code in PR #17784:
URL: https://github.com/apache/nuttx/pull/17784#discussion_r2667106856
##########
sched/hrtimer/hrtimer_cancel.c:
##########
@@ -129,11 +129,13 @@ int hrtimer_cancel(FAR hrtimer_t *hrtimer)
if (hrtimer_is_armed(hrtimer))
{
hrtimer_remove(hrtimer);
- }
- /* Mark timer as cancelled */
+ /* Mark timer as cancelled */
+
+ hrtimer->func = NULL;
+ }
- hrtimer->expired = UINT64_MAX;
+ hrtimer->expired++;
Review Comment:
Why periodic timer can not be cancelled...
Is the below logic not correct?
```
if (period > 0 && hrtimer->expired == expired)
{
hrtimer->expired += period;
/* Ensure no overflow occurs */
DEBUGASSERT(hrtimer->expired > period);
hrtimer_insert(hrtimer);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
