xiaoxiang781216 commented on code in PR #17796:
URL: https://github.com/apache/nuttx/pull/17796#discussion_r2671033137
##########
sched/Makefile:
##########
@@ -43,6 +43,7 @@ include timer/Make.defs
include tls/Make.defs
include wdog/Make.defs
include wqueue/Make.defs
+include hrtimer/Make.defs
Review Comment:
move to new patch
##########
sched/sched/sched_timerexpiration.c:
##########
@@ -433,27 +340,18 @@ static clock_t nxsched_timer_start(clock_t ticks, clock_t
interval)
if (interval != CLOCK_MAX)
{
interval = adjust_next_interval(interval);
- nxsched_timer_tick_start(ticks, interval);
+ wd_start_abstick(&g_sched_event, ticks + interval,
+ nxsched_timer_callback, (wdparm_t)NULL);
Review Comment:
`(wdparm_t)NULL` to `0`
##########
sched/wdog/wd_start.c:
##########
@@ -104,16 +104,18 @@
*
****************************************************************************/
-static inline_function clock_t wd_expiration(clock_t ticks)
+static inline_function void wd_expiration(clock_t ticks)
{
FAR struct wdog_s *wdog;
irqstate_t flags;
wdentry_t func;
wdparm_t arg;
- clock_t ret = CLOCK_MAX;
+ clock_t next_expire = ticks;
Review Comment:
next_ticks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
