fxysunshine commented on code in PR #18016:
URL: https://github.com/apache/nuttx/pull/18016#discussion_r2706645559
##########
sched/task/task_cancelpt.c:
##########
@@ -125,14 +125,13 @@ bool nxnotify_cancellation(FAR struct tcb_s *tcb)
*/
tls->tl_cpstate |= CANCEL_FLAG_CANCEL_PENDING;
- leave_critical_section(flags);
- return true;
+ ret = true;
Review Comment:
<img width="1055" height="695" alt="image"
src="https://github.com/user-attachments/assets/57a9fdaf-50eb-47dd-bbfb-4d7cbd4c3bf1";
/>
@anchao, for the purpose of obtaining ASIL-D functional safety
certification, we shall comply with the design principles for software unit
design and implementation specified in ISO 26262-6:2018. Among these
requirements, the rule of one entry and one exit point for subprograms and
functions shall be implemented by adopting MISRA C:2012 Rule 15.5 as the coding
standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
