almir-okato commented on code in PR #18195:
URL: https://github.com/apache/nuttx/pull/18195#discussion_r2731990634


##########
arch/xtensa/src/common/espressif/esp_loader.c:
##########
@@ -50,6 +50,10 @@
 #  include "esp_rom_uart.h"
 #  include "esp_rom_sys.h"
 #  include "esp_app_format.h"
+#  ifndef CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET
+#    define CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET \
+            CONFIG_BOOTLOADER_OFFSET_IN_FLASH
+#  endif

Review Comment:
   From what I understood, your idea is to make a custom bootloader that will 
boot as a regular Simple Boot, but your main application will be "encapsulated" 
and its header will be in another offset, so when calling the 
`map_rom_segments` it will map the "main application header" from this custom 
offset instead of the first one. Is that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to