tmedicci commented on PR #18195:
URL: https://github.com/apache/nuttx/pull/18195#issuecomment-3807533743

   Hi @Laczen, on my side, there are no issues with creating a customized 
bootloader, but it seems this PR doesn't fully implement it.
   
   Then, I suggest:
   1. Keep just the first commit (`boards/xtensa/essp32: remove alignments for 
simpleboot`):
      1. Please fix the typo `essp32`.
   2. Whenever possible, submit the second commit (with 
`CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET`), with the associated Kconfig 
option and a proper example/documentation. For now, it doesn't have any real 
application, so I think we should postpone it for a more concrete use case.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to