linguini1 commented on PR #18266:
URL: https://github.com/apache/nuttx/pull/18266#issuecomment-3839307958
> test log is added, remove your requested change from pr.
I asked for the logs because a large number of recent PRs from Xiaomi were
AI generated and this one contains some of the same indicators ("files changed"
section, poorly formatted text that look copy-pasted, random claims that have a
lot of repetition).
I don't think the test shows a deadlock fix or a "~20-30% power reduction in
typical scenarios. You are right though that it does at least show nothing
visibly broken, so I won't block this PR further. But I am tired of these
sloppy (often AI-generated) PRs that make undemonstrated claims. I think the PR
description should have some kind of demonstrable proof of a performance
improvement or an issue fix if it's part of the argument for being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
