cederom commented on code in PR #18396:
URL: https://github.com/apache/nuttx/pull/18396#discussion_r2809874838
##########
Documentation/platforms/renesas/rx65n/boards/rx65n-grrose/index.rst:
##########
@@ -491,21 +491,22 @@ mounted at /etc and will look like this at run-time:
nsh>
``/etc/init.d/rc.sysinit`` is system init script; ``/etc/init.d/rcS`` is the
-start-up script; ``/etc/passwd`` is a the password file. It supports a single
-user:
+start-up script; ``/etc/passwd`` is the password file.
-.. code:: text
+The ``/etc/passwd`` file is auto-generated at build time when
+``CONFIG_ETC_ROMFS_GENPASSWD`` is enabled. To configure the admin user and
+password, run ``make menuconfig`` and set:
- USERNAME: admin
- PASSWORD: Administrator
+* ``CONFIG_ETC_ROMFS_GENPASSWD=y``
+* ``CONFIG_ETC_ROMFS_PASSWD_USER`` (default: ``admin``)
+* ``CONFIG_ETC_ROMFS_PASSWD_PASSWORD`` (required, build fails if empty)
- nsh> cat /etc/passwd
- admin:8Tv+Hbmr3pLVb5HHZgd26D:0:0:/
+The password is hashed with TEA at build time using
+``tools/mkpasswd.py``; the plaintext is **not** stored in the firmware.
-The encrypted passwords in the provided passwd file are only valid if the TEA
-key is set to: 012345678 9abcdef0 012345678 9abcdef0. Changes to either the key
-or the password word will require regeneration of the ``nsh_romfimg.h`` header
Review Comment:
This information was important because it explained how key was related to
firmware code, where it was stored, and how to update. I would not remove it.
Merge result should be more informative not less :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
