acassis commented on PR #18396:
URL: https://github.com/apache/nuttx/pull/18396#issuecomment-3905238562

   > @acassis I have fixed the changes suggested by you, and CI was failing 
because password generation was enabled in the defconfig files without setting 
a password. I have now removed `CONFIG_ETC_ROMFS_GENPASSWD` from the affected 
defconfigs so that password generation is not enabled by default. This ensures 
there is no default password while allowing users to explicitly enable and 
configure it if needed.
   
   Ok, since the default password doesn't exist anymore, I used that idea:
   
   Define by default:
   
   ETC_ROMFS_PASSWD_USERNAME = admin
   ETC_ROMFS_PASSWD_PASSWORD = Administrator
   
   So, this ETC_ROMFS_PASSWD_PASSWORD will be used by the python script to 
generate to hash password (please confirm that the generated hash is same hash 
that you just removed from the password file (otherwise we need to PR as a 
Breaking Change).
   
   Then in the final step of Makefile and CMake build check if 
"ETC_ROMFS_PASSWD_PASSWORD == Administrator", if it is equal, print a visible 
warning and ask the user to change the default password.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to