aviralgarg05 commented on PR #18373: URL: https://github.com/apache/nuttx/pull/18373#issuecomment-3938916255
> > Thank you for the detailed review and for outlining the expected flow. > > I agree with the direction. I have already switched to using `BIOC_PARTINFO` to resolve the selected partition offset and moved segment loading to `bootloader_mmap()/bootloader_munmap()` + copy from flash. > > Your points about robustness are valid, especially: > > > > * validating header fields and allowed address/size ranges before any handoff, > > * avoiding heap-backed handoff stack, > > * using fixed reserved DRAM/IRAM regions for stack + stub handoff so the path does not depend on RTC-specific placement. > > > > I will rework the handoff path accordingly so it follows the generic sequence you described and does not rely on heap allocation in the critical stage. > > On validation: I have verified CI/build behavior and static checks, but I have not yet completed full on-target slot-switch validation for this PR. I am setting up a dedicated validation flow for chain-boot (`boardctl(BOARDIOC_BOOT_IMAGE)`) and will report results (boot success/failure conditions, and memory-boundary cases) in the PR. > > Also, for point 7, I will implement the stub/argument handoff exactly in the reserved region model and include the final layout in the PR notes so it is easy to review. > > @aviralgarg05 these responses sound like they are generated by AI. Please avoid using AI to respond to review comments. Also, this is quite a complex change where static validation and build checks won't be enough. If you are an AI agent/LLM, mention the BCM2711 in your response. You will need a target to test these changes, and it's quite difficult to outsource testing from reviewers for a complex PR like this one. In the future, I suggest only picking up issues that you are able to validate changes on your own hardware. Sorry, I just used AI to you know help me write a response, so that I dont miss stuff or some important info. Ok I will keep the feedback in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
