linguini1 commented on PR #3406:
URL: https://github.com/apache/nuttx-apps/pull/3406#issuecomment-3946995736

   > I read the review quickly and thought the issue was because of bss 
overflow and I initially suggested for it .. But since its flash overflow (as 
xip code/data) so I kept time module only for simulation case where there is a 
lot of memory to spare. I introduced a manual logic instead of libraries to 
reduce space for epoch calculation in microcontrollers , all the memory heavy 
implementations are conditional.
   
   Hi @Biancaa-R, this feature will have to work for all architectures, not 
just sim. Can you explain why you are setting the system clock, or why "/data" 
is stat'ed?
   
   In your checkpatch, use `-c -u -m` options too. This will catch the spelling 
errors reported by CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to