Biancaa-R commented on code in PR #3406: URL: https://github.com/apache/nuttx-apps/pull/3406#discussion_r2842941555
########## nshlib/nsh_fscmds.c: ########## @@ -44,9 +44,12 @@ #include <libgen.h> #include <errno.h> #include <debug.h> - #include "nsh.h" +#ifdef CONFIG_ARCH_SIM +# include <time.h> +#endif Review Comment: > @Biancaa-R this could should be generic, so seems like you was guided incorrectly to fix it only for arch SIM. So, please remove this #ifdef / #else check Yes , yes it can be generic but last time I added it and used a function the 128KB flash was overflowed by 4 bytes in the stm board . Thats the reason I tried to avoid that include and made my own implementation for epoch seconds to date time conversion, just so that there is no new mem overflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
