Sumit6307 commented on code in PR #18607:
URL: https://github.com/apache/nuttx/pull/18607#discussion_r2994246910
##########
fs/procfs/Kconfig:
##########
@@ -148,6 +148,16 @@ config FS_PROCFS_EXCLUDE_VERSION
bool "Exclude version"
default DEFAULT_SMALL
+config FS_PROCFS_PROFILER
+ bool "Include fs/profile information"
+ depends on FS_PROFILER && !DEFAULT_SMALL
+ default y
Review Comment:
> @Sumit6307 I'm not sure if PROCFS PROFILER should be enabled by default.
Why to enable something that should be used for benchmarking/debugging purpose?
@xiaoxiang781216 @cederom @simbit18 @raiden00pl @linguini1 @lupyuen @jerpelea
please comment
@acassis You are completely right—I have just pushed an update to make
`FS_PROCFS_PROFILER` default to `n` so it remains purely opt-in for
benchmarking.
Regarding `mnemofs.h` and the `#endif` guard in
[fs_profile.c](cci:7://file:///c:/Users/Sumit/OneDrive/Desktop/GSOC-2026/gsoc-nuttx/gsoc-nuttx/fs/vfs/fs_profile.c:0:0-0:0),
those were artifacts from my very first commit attempt. My recent force-pushes
have entirely cleanly rebased those out of the tree (they do not exist in the
current `HEAD` patch that is being tested right now)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
