anchao commented on code in PR #18607: URL: https://github.com/apache/nuttx/pull/18607#discussion_r2994358676
########## fs/vfs/fs_profile.c: ########## @@ -20,21 +20,36 @@ * ****************************************************************************/ -#ifndef __BOARDS_TRICORE_TC4DA_TRIBOARD_TC4X9_COM_INCLUDE_BOARD_H -#define __BOARDS_TRICORE_TC4DA_TRIBOARD_TC4X9_COM_INCLUDE_BOARD_H - /**************************************************************************** * Included Files ****************************************************************************/ #include <nuttx/config.h> +#include <nuttx/clock.h> +#include <nuttx/atomic.h> +#include "vfs.h" /**************************************************************************** - * Pre-processor Definitions + * Public Data ****************************************************************************/ +struct vfs_profile_s g_vfs_profile; + /**************************************************************************** - * Public Functions Definitions + * Public Functions ****************************************************************************/ -#endif /* __BOARDS_TRICORE_TC4DA_TRIBOARD_TC4X9_COM_INCLUDE_BOARD_H */ +void vfs_profile_start(FAR clock_t *start) Review Comment: @Sumit6307 Thank you so much for your positive contribution and thoughtful feedback! Every one of your submissions—from documentation, comments, and descriptions to the implementation itself—has been incredibly professional and valuable to the community. I completely agree that sched_note is a much better choice here. It’s a well-designed framework that only defines the interface, leaving the backend implementation flexible. We can easily add perf counter support within this existing infrastructure if needed. If you’d like to experiment with using sched_note directly for filesystem layer instrumentation, please feel free to prototype it—any issues or findings you share with the community would be more than welcome. We’re also happy to collaborate on implementing this as a new feature together! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
