aviralgarg05 commented on PR #18652: URL: https://github.com/apache/nuttx/pull/18652#issuecomment-4161914296
> Why can't this fix be done on network driver side? > > Also, how are you able to do such fix on a deep part of the source without even knowing how to build said architecture? Sorry but it is quite an odd approach. My initial reasoning was that the shared mutable object involved in the suspected race is the driver-owned `netdev_rx_queue`. The Wi-Fi RX callback enqueues packets into that queue, while the netdev upper-half RX thread dequeues them, and the IOB queue helpers themselves do not provide internal serialization. Based on that, I considered the lower-half driver to be the narrowest place to address the problem. However, your broader concern is also valid. While I was able to trace the code path and compare it with the older Espressif implementation, that is not a substitute for having the proper toolchain setup and real target testing in place. I should have completed that validation before proposing a fix at this level, and I will correct that before taking this further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
