aviralgarg05 commented on PR #18652: URL: https://github.com/apache/nuttx/pull/18652#issuecomment-4188630251
> Thanks aviralgarg05 > > * Maybe naming it rx_queue_lock instead of rx_lock? rx_lock sounds like protecting rx path rather than just the queue? > * Not for this patch, but seems there are several similar issues? I just did grep > https://github.com/apache/nuttx/blob/78e3f17b9ec80ee01840a52c6ffd190615e1fa3b/drivers/usbdev/cdcncm.c#L1332 Thank you, that is a fair suggestion. I agree that `rx_queue_lock` is a better name here, since the lock is only intended to protect the RX queue itself. I will rename it accordingly. I also agree that this pattern may exist in other places. For this PR, I would prefer to keep the scope limited to the Espressif Wi-Fi RX queue race reported here and handle any broader audit separately so this fix remains focused and easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
