raiden00pl commented on PR #18719: URL: https://github.com/apache/nuttx/pull/18719#issuecomment-4234585293
@xiaoxiang781216 what are the consequences of this change? looking at git history, changes in this macro were made by Xiaomi, so they probably had some purpose: 1. change from `((void)(a))` to `((void)(1 || (a)))`: https://github.com/apache/nuttx/pull/3212 ``` commit 3813634dc98f3b77122bb1fcc17f818f08521225 Author: Xiang Xiao <[email protected]> Date: Mon Mar 29 14:08:03 2021 +0800 Refine UNUSED macro to avoid any side effect Signed-off-by: Xiang Xiao <[email protected]> Change-Id: I35d858fc6fb2e0e24b993ab7dd2203c9dd35232a ``` 2. change from `((void)(1 || (a)))` to `((void)(1 || &(a)))`: https://github.com/apache/nuttx/pull/6779 ``` commit 0083a2e4f29ac8574eeda895803f2a7447d89680 Author: liyi <[email protected]> Date: Thu Aug 4 14:54:31 2022 +0800 optimize UNUSED macro Signed-off-by: liyi <[email protected]> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
