xiaoxiang781216 commented on PR #18719: URL: https://github.com/apache/nuttx/pull/18719#issuecomment-4234862348
> @xiaoxiang781216 what are the consequences of this change? looking at git history, changes in this macro were made by Xiaomi, so they probably had some purpose: > > 1. change from `((void)(a))` to `((void)(1 || (a)))`: > [fs/lfs: Update version to 2.4.0 #3212](https://github.com/apache/nuttx/pull/3212) > > ``` > commit 3813634dc98f3b77122bb1fcc17f818f08521225 > Author: Xiang Xiao <[email protected]> > Date: Mon Mar 29 14:08:03 2021 +0800 > > Refine UNUSED macro to avoid any side effect > > Signed-off-by: Xiang Xiao <[email protected]> > Change-Id: I35d858fc6fb2e0e24b993ab7dd2203c9dd35232a > ``` > my change try to avoid evaluating the argument to generate the side effect, but @pbarada said other OS(e.g. Linux) always evaluate the argument. so it's fine restore the change to align the behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
