lupyuen commented on PR #3479: URL: https://github.com/apache/nuttx-apps/pull/3479#issuecomment-4439066321
@toku-mac Sorry there's a CMake formatting problem: https://github.com/apache/nuttx-apps/actions/runs/25786185066/job/75745216835?pr=3479#step:4:85 ``` ❌ Missing Signed-off-by ERROR __main__.py:618: Check failed: /home/runner/work/nuttx-apps/nuttx-apps/apps/cmake/nuttx_add_rust.cmake cmake-format check failed, run following command to update the style: $ cmake-format <src> -o <dst> ``` Could you run this then commit the the updated CMakefile, remember to add "Signed-off-by" to the commit: ```bash cd cmake python3 -m venv . source ./bin/activate python3 -m pip install cmake-format cmake-format nuttx_add_rust.cmake -o nuttx_add_rust.cmake ``` Here are the changes: ``` $ git diff function(nuttx_rust_target_triple ARCHTYPE ABITYPE CPUTYPE OUTPUT) - get_filename_component(APPDIR "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/.." ABSOLUTE) + get_filename_component(APPDIR "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/.." + ABSOLUTE) if(ARCHTYPE STREQUAL "x86_64") set(TARGET_TRIPLE "${APPDIR}/tools/x86_64-unknown-nuttx.json") elseif(ARCHTYPE STREQUAL "x86") @@ -148,9 +149,9 @@ function(nuttx_add_rust) set(TARGET_BASE ${RUST_TARGET}) endif() - set(RUST_BUILD_DIR - ${CMAKE_CURRENT_BINARY_DIR}/${CRATE_NAME}/target) - set(RUST_LIB_PATH ${RUST_BUILD_DIR}/${TARGET_BASE}/${RUST_PROFILE}/lib${CRATE_NAME}.a) + set(RUST_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CRATE_NAME}/target) + set(RUST_LIB_PATH + ${RUST_BUILD_DIR}/${TARGET_BASE}/${RUST_PROFILE}/lib${CRATE_NAME}.a) # Create build directory file(MAKE_DIRECTORY ${RUST_BUILD_DIR}) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
