no1wudi commented on code in PR #3479:
URL: https://github.com/apache/nuttx-apps/pull/3479#discussion_r3234099111


##########
cmake/nuttx_add_rust.cmake:
##########
@@ -127,9 +129,11 @@ function(nuttx_add_rust)
 
   # Determine build profile based on CONFIG_DEBUG_FULLOPT
   if(CONFIG_DEBUG_FULLOPT)
+    set(RUST_PROFILE_FLAG "-Zjson-target-spec --release")
     set(RUST_PROFILE "release")
     set(RUST_PANIC_FLAGS "-Zunstable-options -Cpanic=immediate-abort")
   else()
+    set(RUST_PROFILE_FLAG "-Zjson-target-spec")

Review Comment:
   I guess if it's essential for x86 target and acceptable for other targets, 
you  can move it to line 166 instead of dup them here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to