nightt5879 opened a new pull request, #3489: URL: https://github.com/apache/nuttx-apps/pull/3489
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary This PR addresses the concrete `open()` argument issues reported in #1879: - `nshlib/nsh_script.c`: pass explicit open flags for the script redirect file, and keep `0666` as the creation mode. - `testing/ostest/aio.c`: pass a mode argument for `open()` calls that use `O_CREAT`. I kept this PR scoped to the examples mentioned in the issue. While checking the tree, I also found other possible `open(..., O_CREAT, ...)` call sites that may need review, so maintainer guidance would be useful on whether to extend this PR or handle those separately. Refs #1879 ## Impact This corrects file creation/opening behavior for the NSH script redirect path and AIO ostest file setup. No configuration, API, or user interface changes are intended. ## Testing Host: - Windows with WSL Ubuntu-24.04 - x86_64 - GCC 13.3.0 Target: - `sim:nsh` Commands: ```sh cd /tmp/nuttx-verify-1879/nuttx make -j$(nproc) kconfig-tweak --enable FS_AIO --enable TESTING_OSTEST_AIO --set-str TESTING_OSTEST_AIOPATH /tmp make olddefconfig make -j$(nproc) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
