nightt5879 commented on PR #3489:
URL: https://github.com/apache/nuttx-apps/pull/3489#issuecomment-4494172094
@xiaoxiang781216 Thanks, I checked the typo warnings.
The `bufffer` and `cummulative` warnings are straightforward typos, and I
can fix them directly.
For `system/nxcamera/nxcamera.c`, I can rename the local variable from
`parm` to `param`, but there are still two remaining `parm` occurrences in the
V4L2 API field access:
param.parm.capture.timeperframe.denominator = framerate;
param.parm.capture.timeperframe.numerator = 1;
That `.parm` is a field name from `struct v4l2_streamparm`, so it cannot be
renamed in this app code.
Which approach do you prefer?
1. Add `parm` to the apps `.codespellrc` ignore words list. This would match
the main `apache/nuttx` repository, where `parm` is already ignored.
2. Add only these two `param.parm...` lines to `.codespell-ignore-lines`, so
the ignore is limited to this V4L2 API field usage.
I slightly prefer option 1 for consistency with the main NuttX repository,
but I can use either approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
