nightt5879 commented on PR #3511: URL: https://github.com/apache/nuttx-apps/pull/3511#issuecomment-4575931796
> > Thanks, I added a small `testing/libc/popen` test in commit [23a698f](https://github.com/apache/nuttx-apps/commit/23a698fde9de2f8b41c3e6868a415f5a13eed6d1). @acassis > > The test opens two `popen(..., "r")` streams, verifies the output read from both streams, and closes the first stream before the second. That covers reading from the returned `popen()` stream and also exercises the private stream-to-pid lookup/removal path added by this PR when the stream is not the first entry in the tracking list. > > I verified the added test with: > > ``` > > * `checkpatch.sh -g HEAD~1..HEAD` > > > > * `sim:nsh` build with `CONFIG_SYSTEM_POPEN=y` and `CONFIG_TESTING_POPEN_TEST=y` > > > > * `printf 'popen_test\npoweroff\n' | timeout 30s ./nuttx` > > ``` > > > > > > > > > > > > > > > > > > > > > > > > The simulator run prints `popen_test: successful`. > > My bad, I looked only the first commit. So, everything is fine! Just to clarify: I added the additional commit after seeing your suggestion. Thanks for reviewing it again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
