Abhishekmishra2808 commented on code in PR #3552:
URL: https://github.com/apache/nuttx-apps/pull/3552#discussion_r3443850472


##########
nshlib/nsh_prompt.c:
##########
@@ -90,6 +98,27 @@ void nsh_update_prompt(void)
       gethostname(g_nshprompt, NSH_PROMPT_SIZE);
       strcat(g_nshprompt, CONFIG_NSH_PROMPT_SUFFIX);
     }
+
+#if defined(CONFIG_SCHED_USER_IDENTITY)
+  FAR const char *privprompt = NULL;
+
+  if (geteuid() == 0)
+    {
+      if (CONFIG_NSH_PROMPT_STRING_ROOT[0] != '\0')
+        {
+          privprompt = CONFIG_NSH_PROMPT_STRING_ROOT;

Review Comment:
   Direct copy needs non-blank defaults and would break citest CI unless we 
also update defconfigs/CI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to