Abhishekmishra2808 commented on code in PR #3552: URL: https://github.com/apache/nuttx-apps/pull/3552#discussion_r3444297286
########## nshlib/nsh_identity.c: ########## @@ -0,0 +1,498 @@ +/**************************************************************************** + * apps/nshlib/nsh_identity.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <ctype.h> +#include <errno.h> +#include <pwd.h> +#include <stdio.h> +#include <stdbool.h> +#include <string.h> +#include <unistd.h> +#include <termios.h> + +#ifdef CONFIG_NSH_CLE +# include "system/cle.h" +#else +# include "system/readline.h" +#endif + +#if defined(CONFIG_NSH_LOGIN_PASSWD) +# include "fsutils/passwd.h" +#endif + +#include "nshlib/nshlib.h" +#include "nsh.h" +#include "nsh_console.h" + +#if defined(CONFIG_SCHED_USER_IDENTITY) + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: nsh_is_privileged + * + * Description: + * Return true if the caller has root privileges (effective UID or GID is + * zero). NuttX does not support supplementary groups; membership in the + * root group is indicated by a primary GID of zero. + * + ****************************************************************************/ + +static bool nsh_is_privileged(void) +{ + return geteuid() == 0 || getegid() == 0; +} + +#ifdef CONFIG_LIBC_PASSWD_FILE +# ifndef CONFIG_LIBC_PASSWD_LINESIZE +# define CONFIG_LIBC_PASSWD_LINESIZE 128 Review Comment: Yes, fixed. ########## nshlib/nsh_identity.c: ########## @@ -0,0 +1,498 @@ +/**************************************************************************** + * apps/nshlib/nsh_identity.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <ctype.h> +#include <errno.h> +#include <pwd.h> +#include <stdio.h> +#include <stdbool.h> +#include <string.h> +#include <unistd.h> +#include <termios.h> + +#ifdef CONFIG_NSH_CLE +# include "system/cle.h" +#else +# include "system/readline.h" +#endif + +#if defined(CONFIG_NSH_LOGIN_PASSWD) Review Comment: Done ########## nshlib/nsh_identity.c: ########## @@ -0,0 +1,498 @@ +/**************************************************************************** + * apps/nshlib/nsh_identity.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <ctype.h> +#include <errno.h> +#include <pwd.h> +#include <stdio.h> +#include <stdbool.h> +#include <string.h> +#include <unistd.h> +#include <termios.h> + +#ifdef CONFIG_NSH_CLE +# include "system/cle.h" +#else +# include "system/readline.h" +#endif + +#if defined(CONFIG_NSH_LOGIN_PASSWD) +# include "fsutils/passwd.h" +#endif + +#include "nshlib/nshlib.h" +#include "nsh.h" +#include "nsh_console.h" + +#if defined(CONFIG_SCHED_USER_IDENTITY) + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: nsh_is_privileged + * + * Description: + * Return true if the caller has root privileges (effective UID or GID is + * zero). NuttX does not support supplementary groups; membership in the + * root group is indicated by a primary GID of zero. + * + ****************************************************************************/ + +static bool nsh_is_privileged(void) +{ + return geteuid() == 0 || getegid() == 0; +} + +#ifdef CONFIG_LIBC_PASSWD_FILE +# ifndef CONFIG_LIBC_PASSWD_LINESIZE +# define CONFIG_LIBC_PASSWD_LINESIZE 128 +# endif + +/**************************************************************************** + * Name: nsh_lookup_user + * + * Description: + * Look up a passwd entry by name using re-entrant libc helpers. + * + ****************************************************************************/ + +static int nsh_lookup_user(FAR const char *username, uid_t *uid, gid_t *gid) +{ + struct passwd pwd; + struct passwd *result; + char buf[CONFIG_LIBC_PASSWD_LINESIZE]; + int ret; + + ret = getpwnam_r(username, &pwd, buf, sizeof(buf), &result); + if (ret != 0) + { + return -ret; + } + + if (result == NULL) + { + return -ENOENT; + } + + *uid = result->pw_uid; + *gid = result->pw_gid; + return OK; +} +#endif /* CONFIG_LIBC_PASSWD_FILE */ + +#if defined(CONFIG_NSH_LOGIN) Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
