xiaoxiang781216 commented on code in PR #3564: URL: https://github.com/apache/nuttx-apps/pull/3564#discussion_r3481667677
########## interpreters/berry/Kconfig: ########## @@ -0,0 +1,43 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config INTERPRETERS_BERRY + tristate "Berry scripting language" + default n + select ARCH_SETJMP_H + select LIBC_FLOATINGPOINT + select SYSTEM_SYSTEM Review Comment: it's better to change to `depends on XXX` ########## interpreters/berry/0001-Fix-Berry-default-port-for-NuttX.patch: ########## @@ -0,0 +1,27 @@ +diff --git a/default/berry.c b/default/berry.c +index d6ea5d1..bb95fc7 100644 +--- a/default/berry.c ++++ b/default/berry.c +@@ -22 +22,3 @@ +-#if defined(__linux) ++#if defined(__NuttX__) ++ #define OS_NAME "NuttX" ++#elif defined(__linux) +@@ -103 +105 @@ +- const char *optarg; ++ const char *optvalue; Review Comment: ALL change is general, so it's better to upstream to Berry community. ########## interpreters/berry/README.md: ########## @@ -0,0 +1,32 @@ +# Berry Interpreter + +Berry is an embedded scripting language implemented in ANSI C99. This app Review Comment: move to nuttx/Documentation near other script language ########## interpreters/berry/include/berry_conf.h: ########## @@ -0,0 +1,78 @@ +/**************************************************************************** + * apps/interpreters/berry/include/berry_conf.h Review Comment: it's better to enable berry by add sim:berry in boards/sim folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
