speccy88 commented on code in PR #3564: URL: https://github.com/apache/nuttx-apps/pull/3564#discussion_r3484769694
########## interpreters/berry/include/berry_conf.h: ########## @@ -0,0 +1,78 @@ +/**************************************************************************** + * apps/interpreters/berry/include/berry_conf.h Review Comment: Done. I added sim:berry plus Berry documentation in the NuttX-side companion PR: https://github.com/apache/nuttx/pull/19224. ########## interpreters/berry/0001-Fix-Berry-default-port-for-NuttX.patch: ########## @@ -0,0 +1,27 @@ +diff --git a/default/berry.c b/default/berry.c +index d6ea5d1..bb95fc7 100644 +--- a/default/berry.c ++++ b/default/berry.c +@@ -22 +22,3 @@ +-#if defined(__linux) ++#if defined(__NuttX__) ++ #define OS_NAME "NuttX" ++#elif defined(__linux) +@@ -103 +105 @@ +- const char *optarg; ++ const char *optvalue; Review Comment: Done. I opened the upstream Berry PR for these general default-port changes here: https://github.com/skiars/berry/pull/1. Keeping this NuttX patch while that upstream PR is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
