Shriyans406 commented on PR #19359:
URL: https://github.com/apache/nuttx/pull/19359#issuecomment-4911472480
@raiden00pl, Alan C. Assis, @linguini1, @xiaoxiang781216
Dear all
Thanks for the feedback, I have just pushed an updated commit series that
addresses all of your points.
1. Fixed the massive diffs in Kconfig/Make.defs: The large diffs were
accidentally caused by Windows CRLF line-ending conversions in my editor.
I
have converted all line endings to UNIX, so the diffs would be only 4
lines
each.
2. Migrated to the modern uORB Sensor Framework: As @xiaoxiang781216
noted,
the existing mpu60x0.c driver implements a legacy custom
character-driver interface. Following the official NuttX sensor
guidelines,
I have completely removed the legacy character driver approach and
implemented a modern lower-half uORB sensor driver (mpu6050_uorb.c)
supporting both accelerometer (sensor_accel0) and gyroscope (sensor_gyro0)
topics.
On Wed, Jul 8, 2026 at 9:58 AM Xiang Xiao ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In drivers/sensors/mpu6050.c
> <https://github.com/apache/nuttx/pull/19359#discussion_r3541204097>:
>
> > +}
> +
> +/**
> + * Name: mpu6050_close
> + */
> +
> +static int mpu6050_close(FAR struct file *filep)
> +{
> + return OK;
> +}
> +
> +/**
> + * Name: mpu6050_read
> + */
> +
> +static ssize_t mpu6050_read(FAR struct file *filep, FAR char *buffer,
>
> BTW, does
> https://github.com/apache/nuttx/blob/master/drivers/sensors/mpu60x0.c
> work for you? yes, it implements the custom interface, we may need migrate
> it to the new sensor driver framework.
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/nuttx/pull/19359?email_source=notifications&email_token=BMTFX7X4DXF7ABVWHL2DSYD5DXEXDA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRVGA4TANRQGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r3541204097>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/BMTFX7WLZDASYKNATDSASCT5DXEXDAVCNFSNUABFKJSXA33TNF2G64TZHMZDEOBRGAZTENZTHNEXG43VMU5TIOBSG4ZTCOBVGI42C5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
>
<https://github.com/notifications/mobile/ios/BMTFX7WGHDEG4R2HFOLJ3RT5DXEXDA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRVGA4TANRQGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
>
<https://github.com/notifications/mobile/android/BMTFX7T7IPGN627ILNVLTLD5DXEXDA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRVGA4TANRQGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
