ricardgb commented on PR #19250:
URL: https://github.com/apache/nuttx/pull/19250#issuecomment-4955677653
Pushed an update addressing the review:
- **@xiaoxiang781216** — both inline comments addressed: `STRINGIFY()` from
`nuttx/macro.h` now used in `rp23xx_firmware.c` (replies in-thread), and I
answered the `CYW43439_FIRMWARE_LEN` question above.
- **DCO** — the three `Missing Signed-off-by` failures in the `check` job
were commits 2–4 of this PR; all four commits now carry a `Signed-off-by`.
`tools/checkpatch.sh -c -u -m -g` passes locally on the series.
- **nxstyle** — fixed the brace-alignment errors in
`rp23xx_common_bringup.c` (the boot-helper spawn block no longer uses a bare
`{}` scope; declarations are hoisted under the same `#ifdef`).
- **@acassis** — I could not reproduce the earlier `undefined reference to
\`board_late_initialize'` link error on the current head:
`CONFIG_BOARD_LATE_INITIALIZE` now defaults `y` and the board defines it, so
`raspberrypi-pico-2-w:telnet` links cleanly here (arm-none-eabi-gcc 13.2).
Hopefully the CI build agrees now — please let me know if it still fails on
your side.
- **@cederom** — board documentation is included at
`Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2-w/index.rst`, and
I'll expand the PR description with the build + on-hardware runtime testing
details.
*Disclosure: these changes were prepared with the help of an AI agent and
human-reviewed before pushing.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
