ricardgb commented on code in PR #19250: URL: https://github.com/apache/nuttx/pull/19250#discussion_r3523575074
########## boards/arm/rp23xx/raspberrypi-pico-2-w/src/rp23xx_firmware.c: ########## @@ -0,0 +1,160 @@ +/**************************************************************************** + * boards/arm/rp23xx/raspberrypi-pico-2-w/src/rp23xx_firmware.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <stdint.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define _STR(x) #x +#define STR(x) _STR(x) + +#define ROUNDED_FIRMWARE_LEN ((CONFIG_CYW43439_FIRMWARE_LEN + 0xff) & ~0xff) + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +#ifdef CONFIG_IEEE80211_INFINEON_CYW43439 + +/**************************************************************************** + * Character array of NVRAM image + * Generated from cyw943439wlpth_rev1_0.txt + * $ Copyright Broadcom Corporation $ Review Comment: The NVRAM and firmware come from the cyw43-driver (George Robotics / Broadcom); its license (non-commercial in LICENSE, RP-silicon-only in LICENSE.RP) is not Apache-2.0-compatible. I didn't fully vet that, and I've since noticed the identical NVRAM already ships in rp2040_firmware.c for the pico-w under an Apache header, so this looks like a pre-existing licensing issue affecting the RP2040 board too, not just my PR. On the protocol: there's no public CYW43439 datasheet, so the driver isn't reverse-engineered — it's a port of NuttX's existing RP2040 gSPI/bcmf implementation. And to be upfront (as I have been), this port was done with Claude Code; I'm reviewing and standing behind the portability work, but I'll defer to the maintainers on the firmware-licensing question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
