casaroli commented on PR #19585: URL: https://github.com/apache/nuttx/pull/19585#issuecomment-5143269879
> Hi, the build is failing in mainline. It’s a LAME link error (*_avx512 undefined) from apps, likely a CMake gap after [nuttx-apps#3666](https://github.com/apache/nuttx-apps/pull/3666) (SSE2/AVX2 added, AVX512 still enabled by configure). > > @casaroli, please help us to add AVX512 vector sources in the sim/CMake LAME build. Thanks! > > @xiaoxiang781216 and @acassis PTAL. I can fix the cmake file again, however the root problem is that lame revision is not pinned, so when it updated, it breaks: - [Makefile:26](https://github.com/apache/nuttx-apps/blob/2631d3e59add05e4099ff1df7e6b0f20d0b4a979/audioutils/lame/Makefile#L26) - [CMakeLists.txt:42](https://github.com/apache/nuttx-apps/blob/2631d3e59add05e4099ff1df7e6b0f20d0b4a979/audioutils/lame/CMakeLists.txt#L42) So when they update, sometimes it breaks: I believe our options are: 1. Pin lame to `r6718` 2. Pin lame to `r6720` and fix the CMakeLists.txt once more 3. Do not Pin lame and keep fixing CMakeLists.txt forever 4. Try to contribute to lame so their upstream cmake build can be just included / called from us. I think 3 is bad decision I recommend we do (1) -> (4); or (2) -> (4) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
