Abhishekmishra2808 commented on code in PR #19585: URL: https://github.com/apache/nuttx/pull/19585#discussion_r3695683029
########## binfmt/binfmt.h: ########## @@ -231,6 +231,17 @@ void binfmt_freeactions(FAR const posix_spawn_file_actions_t *copy); ****************************************************************************/ int binfmt_checkexecperm(FAR struct binary_s *bin); Review Comment: done ########## binfmt/binfmt_execidentity.c: ########## @@ -0,0 +1,92 @@ +/**************************************************************************** + * binfmt/binfmt_execidentity.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <sys/stat.h> + +#include <nuttx/binfmt/binfmt.h> +#include <nuttx/sched.h> + +#include "binfmt.h" +#include "environ/environ.h" + +#ifndef CONFIG_BINFMT_DISABLE Review Comment: removed ########## binfmt/binfmt_execidentity.c: ########## @@ -0,0 +1,92 @@ +/**************************************************************************** + * binfmt/binfmt_execidentity.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <sys/stat.h> + +#include <nuttx/binfmt/binfmt.h> +#include <nuttx/sched.h> + +#include "binfmt.h" +#include "environ/environ.h" + +#ifndef CONFIG_BINFMT_DISABLE + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: binfmt_applyexecidentity + * + * Description: + * Apply set-user-ID and set-group-ID semantics for a newly loaded program + * image. When either bit is set in the executable file mode, the + * effective and saved set-IDs are updated, the task group is marked as + * executing securely, debug state is cleared, and the environment is + * sanitized. + * + ****************************************************************************/ + +#ifdef CONFIG_SCHED_USER_IDENTITY Review Comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
